SkillAPI updated to Fabled #448
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davight
reviewed
Jun 23, 2025
| // CONSTRUCTORS | ||
| ///////////////// | ||
|
|
||
| static FabledClass fabledClass; |
davight
reviewed
Jun 23, 2025
|
|
||
| public class FabledPlayerExtensions { | ||
|
|
||
| public FabledPlayerExtensions(PlayerTag player) { |
davight
reviewed
Jun 23, 2025
Comment on lines
17
to
20
| static Skill fabledSkill; | ||
| static FabledClass fabledClass; | ||
| static PlayerClass playerClass; | ||
| static PlayerSkill playerSkill; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SkillAPI hasn't been updated since 2018. Fabled has taken to keeping it updated past 1.12, and generously kept the legacy packages in place just for us.
Huge thanks to @Travja for ensuring compatibility through magemonkeystudio/fabled@424deb6, hopefully you'll be able to remove these names after this gets merged.
Resolves #355
Resolves #399
Reported as an issue in https://discord.com/channels/315163488085475337/1298273433896878181
Recommended action in https://discord.com/channels/315163488085475337/1011496047811506227/1374597146115965039