Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix REST endpoints for adding tags #4541

Merged
merged 1 commit into from
Jan 11, 2025
Merged

Conversation

nscuro
Copy link
Member

@nscuro nscuro commented Jan 11, 2025

Description

Fixes REST endpoints for adding tags.

The /tag/{name}/project endpoint did not add the provided tag to projects which already had tags assigned to them.

The /tag/{name}/policy and /tag/{name}/notificationRule endpoints replaced existing tags with the provided tag, which is not the intended behavior. Since only one tag can be provided via path parameter, the tag should be added to existing tags, not replace them.

Addressed Issue

Fixes #4539

Additional Details

N/A

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

The `/tag/{name}/project` endpoint did not add the provided tag to projects which already had tags assigned to them.

The `/tag/{name}/policy` and `/tag/{name}/notificationRule` endpoints replaced existing tags with the provided tag, which is not the intended behavior. Since only one tag can be provided via path parameter, the tag should be *added* to existing tags, not replace them.

Fixes DependencyTrack#4539

Signed-off-by: nscuro <[email protected]>
@nscuro nscuro added defect Something isn't working backport/4.12.3 PRs to be backported to version 4.12.3 labels Jan 11, 2025
@nscuro nscuro added this to the 4.13 milestone Jan 11, 2025
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 90.00% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (bcd2651) 23013 18284 79.45%
Head commit (cb4590f) 23023 (+10) 18293 (+9) 79.46% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#4541) 40 36 90.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@nscuro nscuro merged commit a546763 into DependencyTrack:master Jan 11, 2025
11 checks passed
@nscuro nscuro deleted the issue-4539 branch January 11, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/4.12.3 PRs to be backported to version 4.12.3 defect Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tag doesn't get appended to project when added over API and project already has a tag
1 participant