Skip to content

Commit

Permalink
Added cmake-generated Git version constants
Browse files Browse the repository at this point in the history
I added a new custom CMake module, downloaded from GitHub, that makes
the output of git describe available in CMake. I then used this to make
CMake procedurally generate a .cpp file containing some constants for
the current Derecho version number according to Git. This allows
version_code.cpp to refer to the actual current Derecho version, not a
hardcoded constant, so this closes #90.

I also used the new constants to print a message including the current
Derecho version when Derecho starts up, and to append the current
Derecho version to all error messages printed by derecho_exception. This
closes #94.
  • Loading branch information
etremel committed Apr 10, 2019
1 parent 1058542 commit 27f0a99
Show file tree
Hide file tree
Showing 9 changed files with 324 additions and 10 deletions.
1 change: 1 addition & 0 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ set(CMAKE_CXX_FLAGS_RELEASE "${CMAKE_CXX_FLAGS} -O3 -Wall -DNOLOG")
set(CMAKE_CXX_FLAGS_RELWITHDEBINFO "${CMAKE_CXX_FLAGS} -O3 -Wall -ggdb -gdwarf-3 -DNOLOG")

set(CMAKE_MODULE_PATH "${CMAKE_SOURCE_DIR}/cmake/Modules")
include(GetGitRevisionDescription)

# mutils_FOUND
# mutils_INCLUDE_DIRS
Expand Down
168 changes: 168 additions & 0 deletions cmake/Modules/GetGitRevisionDescription.cmake
Original file line number Diff line number Diff line change
@@ -0,0 +1,168 @@
# - Returns a version string from Git
#
# These functions force a re-configure on each git commit so that you can
# trust the values of the variables in your build system.
#
# get_git_head_revision(<refspecvar> <hashvar> [<additional arguments to git describe> ...])
#
# Returns the refspec and sha hash of the current head revision
#
# git_describe(<var> [<additional arguments to git describe> ...])
#
# Returns the results of git describe on the source tree, and adjusting
# the output so that it tests false if an error occurs.
#
# git_get_exact_tag(<var> [<additional arguments to git describe> ...])
#
# Returns the results of git describe --exact-match on the source tree,
# and adjusting the output so that it tests false if there was no exact
# matching tag.
#
# git_local_changes(<var>)
#
# Returns either "CLEAN" or "DIRTY" with respect to uncommitted changes.
# Uses the return code of "git diff-index --quiet HEAD --".
# Does not regard untracked files.
#
# Requires CMake 2.6 or newer (uses the 'function' command)
#
# Original Author:
# 2009-2010 Ryan Pavlik <[email protected]> <[email protected]>
# http://academic.cleardefinition.com
# Iowa State University HCI Graduate Program/VRAC
#
# Copyright Iowa State University 2009-2010.
# Distributed under the Boost Software License, Version 1.0.
# (See accompanying file LICENSE_1_0.txt or copy at
# http://www.boost.org/LICENSE_1_0.txt)

if(__get_git_revision_description)
return()
endif()
set(__get_git_revision_description YES)

# We must run the following at "include" time, not at function call time,
# to find the path to this module rather than the path to a calling list file
get_filename_component(_gitdescmoddir ${CMAKE_CURRENT_LIST_FILE} PATH)

function(get_git_head_revision _refspecvar _hashvar)
set(GIT_PARENT_DIR "${CMAKE_CURRENT_SOURCE_DIR}")
set(GIT_DIR "${GIT_PARENT_DIR}/.git")
while(NOT EXISTS "${GIT_DIR}") # .git dir not found, search parent directories
set(GIT_PREVIOUS_PARENT "${GIT_PARENT_DIR}")
get_filename_component(GIT_PARENT_DIR ${GIT_PARENT_DIR} PATH)
if(GIT_PARENT_DIR STREQUAL GIT_PREVIOUS_PARENT)
# We have reached the root directory, we are not in git
set(${_refspecvar} "GITDIR-NOTFOUND" PARENT_SCOPE)
set(${_hashvar} "GITDIR-NOTFOUND" PARENT_SCOPE)
return()
endif()
set(GIT_DIR "${GIT_PARENT_DIR}/.git")
endwhile()
# check if this is a submodule
if(NOT IS_DIRECTORY ${GIT_DIR})
file(READ ${GIT_DIR} submodule)
string(REGEX REPLACE "gitdir: (.*)\n$" "\\1" GIT_DIR_RELATIVE ${submodule})
get_filename_component(SUBMODULE_DIR ${GIT_DIR} PATH)
get_filename_component(GIT_DIR ${SUBMODULE_DIR}/${GIT_DIR_RELATIVE} ABSOLUTE)
endif()
set(GIT_DATA "${CMAKE_CURRENT_BINARY_DIR}/CMakeFiles/git-data")
if(NOT EXISTS "${GIT_DATA}")
file(MAKE_DIRECTORY "${GIT_DATA}")
endif()

if(NOT EXISTS "${GIT_DIR}/HEAD")
return()
endif()
set(HEAD_FILE "${GIT_DATA}/HEAD")
configure_file("${GIT_DIR}/HEAD" "${HEAD_FILE}" COPYONLY)

configure_file("${_gitdescmoddir}/GetGitRevisionDescription.cmake.in"
"${GIT_DATA}/grabRef.cmake"
@ONLY)
include("${GIT_DATA}/grabRef.cmake")

set(${_refspecvar} "${HEAD_REF}" PARENT_SCOPE)
set(${_hashvar} "${HEAD_HASH}" PARENT_SCOPE)
endfunction()

function(git_describe _var)
if(NOT GIT_FOUND)
find_package(Git QUIET)
endif()
get_git_head_revision(refspec hash)
if(NOT GIT_FOUND)
set(${_var} "GIT-NOTFOUND" PARENT_SCOPE)
return()
endif()
if(NOT hash)
set(${_var} "HEAD-HASH-NOTFOUND" PARENT_SCOPE)
return()
endif()

# TODO sanitize
#if((${ARGN}" MATCHES "&&") OR
# (ARGN MATCHES "||") OR
# (ARGN MATCHES "\\;"))
# message("Please report the following error to the project!")
# message(FATAL_ERROR "Looks like someone's doing something nefarious with git_describe! Passed arguments ${ARGN}")
#endif()

#message(STATUS "Arguments to execute_process: ${ARGN}")

execute_process(COMMAND
"${GIT_EXECUTABLE}"
describe
${hash}
${ARGN}
WORKING_DIRECTORY
"${CMAKE_CURRENT_SOURCE_DIR}"
RESULT_VARIABLE
res
OUTPUT_VARIABLE
out
ERROR_QUIET
OUTPUT_STRIP_TRAILING_WHITESPACE)
if(NOT res EQUAL 0)
set(out "${out}-${res}-NOTFOUND")
endif()

set(${_var} "${out}" PARENT_SCOPE)
endfunction()

function(git_get_exact_tag _var)
git_describe(out --exact-match ${ARGN})
set(${_var} "${out}" PARENT_SCOPE)
endfunction()

function(git_local_changes _var)
if(NOT GIT_FOUND)
find_package(Git QUIET)
endif()
get_git_head_revision(refspec hash)
if(NOT GIT_FOUND)
set(${_var} "GIT-NOTFOUND" PARENT_SCOPE)
return()
endif()
if(NOT hash)
set(${_var} "HEAD-HASH-NOTFOUND" PARENT_SCOPE)
return()
endif()

execute_process(COMMAND
"${GIT_EXECUTABLE}"
diff-index --quiet HEAD --
WORKING_DIRECTORY
"${CMAKE_CURRENT_SOURCE_DIR}"
RESULT_VARIABLE
res
OUTPUT_VARIABLE
out
ERROR_QUIET
OUTPUT_STRIP_TRAILING_WHITESPACE)
if(res EQUAL 0)
set(${_var} "CLEAN" PARENT_SCOPE)
else()
set(${_var} "DIRTY" PARENT_SCOPE)
endif()
endfunction()
41 changes: 41 additions & 0 deletions cmake/Modules/GetGitRevisionDescription.cmake.in
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
#
# Internal file for GetGitRevisionDescription.cmake
#
# Requires CMake 2.6 or newer (uses the 'function' command)
#
# Original Author:
# 2009-2010 Ryan Pavlik <[email protected]> <[email protected]>
# http://academic.cleardefinition.com
# Iowa State University HCI Graduate Program/VRAC
#
# Copyright Iowa State University 2009-2010.
# Distributed under the Boost Software License, Version 1.0.
# (See accompanying file LICENSE_1_0.txt or copy at
# http://www.boost.org/LICENSE_1_0.txt)

set(HEAD_HASH)

file(READ "@HEAD_FILE@" HEAD_CONTENTS LIMIT 1024)

string(STRIP "${HEAD_CONTENTS}" HEAD_CONTENTS)
if(HEAD_CONTENTS MATCHES "ref")
# named branch
string(REPLACE "ref: " "" HEAD_REF "${HEAD_CONTENTS}")
if(EXISTS "@GIT_DIR@/${HEAD_REF}")
configure_file("@GIT_DIR@/${HEAD_REF}" "@GIT_DATA@/head-ref" COPYONLY)
else()
configure_file("@GIT_DIR@/packed-refs" "@GIT_DATA@/packed-refs" COPYONLY)
file(READ "@GIT_DATA@/packed-refs" PACKED_REFS)
if(${PACKED_REFS} MATCHES "([0-9a-z]*) ${HEAD_REF}")
set(HEAD_HASH "${CMAKE_MATCH_1}")
endif()
endif()
else()
# detached HEAD
configure_file("@GIT_DIR@/HEAD" "@GIT_DATA@/head-ref" COPYONLY)
endif()

if(NOT HEAD_HASH)
file(READ "@GIT_DATA@/head-ref" HEAD_HASH LIMIT 1024)
string(STRIP "${HEAD_HASH}" HEAD_HASH)
endif()
6 changes: 5 additions & 1 deletion include/derecho/core/derecho_exception.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@

#include <exception>
#include <string>
#include <sstream>
#include <derecho/core/git_version.hpp>

namespace derecho {

Expand All @@ -18,7 +20,9 @@ struct derecho_exception : public std::exception {
const std::string message;
derecho_exception(const std::string& message) : message(message) {}

const char* what() const noexcept { return message.c_str(); }
const char* what() const noexcept {
return (message + " Derecho version: " + VERSION_STRING_PLUS_COMMITS).c_str();
}
};

/**
Expand Down
42 changes: 42 additions & 0 deletions include/derecho/core/git_version.hpp
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
#pragma once

namespace derecho {

/**
* The current major version number of the Derecho library, as defined by Git.
* This is updated when the library is compiled.
*/
extern const int MAJOR_VERSION;
/**
* The current minor version number of the Derecho library, as defined by Git.
* This is updated when the library is compiled.
*/
extern const int MINOR_VERSION;
/**
* The current "patch" (more-minor) version number of the Derecho library, as
* defined by Git. This is updated when the library is compiled.
*/
extern const int PATCH_VERSION;
/**
* If the currently-compiled version of the Derecho library is more recent than
* the last "release" version, this is the number of Git commits by which it is
* ahead. This is updated when the library is compiled.
*/
extern const int COMMITS_AHEAD_OF_VERSION;

/**
* A constant C-style string containing the current Derecho library version in
* dot-separated format, e.g. "1.0.0"
*/
extern const char* VERSION_STRING;

/**
* A constant C-style string containing the current Derecho library version in
* dot-separated format, plus the number of Git commits the code is ahead of
* the last "release" version, separated by a plus sign. E.g. "1.0.0+5"
*/
extern const char* VERSION_STRING_PLUS_COMMITS;

}


11 changes: 10 additions & 1 deletion src/core/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,16 @@ set(CMAKE_CXX_FLAGS_DEBUG "-O0 -ggdb -gdwarf-3 -pg")
set(CMAKE_CXX_FLAGS_RELEASE "-O3")
set(CMAKE_CXX_FLAGS_RELWITHDEBINFO "-O3 -ggdb -gdwarf-3 -D_PERFORMANCE_DEBUG")

add_library(core OBJECT derecho_sst.cpp view.cpp view_manager.cpp rpc_manager.cpp p2p_connections.cpp multicast_group.cpp subgroup_functions.cpp connection_manager.cpp restart_state.cpp persistence_manager.cpp version_code.cpp)
git_describe(GIT_VERSION_STRING --tags --long)
string(REGEX MATCH "v([0-9]+)\\.([0-9]+)\\.?([0-9]*)-([0-9]+)-g([0-9|a-z]+)" MATCH_OUTPUT ${GIT_VERSION_STRING})
set(DERECHO_MAJOR_VERSION ${CMAKE_MATCH_1})
set(DERECHO_MINOR_VERSION ${CMAKE_MATCH_2})
set(DERECHO_PATCH_VERSION ${CMAKE_MATCH_3})
set(DERECHO_COMMITS_AHEAD ${CMAKE_MATCH_4})
set(DERECHO_COMMIT_HASH ${CMAKE_MATCH_5})
configure_file(git_version.cpp.in git_version.cpp)

add_library(core OBJECT derecho_sst.cpp view.cpp view_manager.cpp rpc_manager.cpp p2p_connections.cpp multicast_group.cpp subgroup_functions.cpp connection_manager.cpp restart_state.cpp persistence_manager.cpp version_code.cpp ${CMAKE_CURRENT_BINARY_DIR}/git_version.cpp)
target_include_directories(core PRIVATE
$<BUILD_INTERFACE:${CMAKE_SOURCE_DIR}/include>
$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}>
Expand Down
49 changes: 49 additions & 0 deletions src/core/git_version.cpp.in
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
/**
* @file git_version.cpp.in
* This is a CMake template file that generates the file git_version.cpp. It is
* used to define the constants in git_version.hpp.
*/

#include <derecho/core/git_version.hpp>

#cmakedefine DERECHO_MAJOR_VERSION @DERECHO_MAJOR_VERSION@
#cmakedefine DERECHO_MINOR_VERSION @DERECHO_MINOR_VERSION@
#cmakedefine DERECHO_PATCH_VERSION @DERECHO_PATCH_VERSION@
#cmakedefine DERECHO_COMMITS_AHEAD @DERECHO_COMMITS_AHEAD@

#ifndef DERECHO_MAJOR_VERSION
#define DERECHO_MAJOR_VERSION 0
#endif
#ifndef DERECHO_MINOR_VERSION
#define DERECHO_MINOR_VERSION 0
#endif
#ifndef DERECHO_PATCH_VERSION
#define DERECHO_PATCH_VERSION 0
#endif
#ifndef DERECHO_COMMITS_AHEAD
#define DERECHO_COMMITS_AHEAD 0
#endif

#define STR(x) #x
#define QUOTE(x) STR(x)

namespace derecho {

const int MAJOR_VERSION = DERECHO_MAJOR_VERSION;
const int MINOR_VERSION = DERECHO_MINOR_VERSION;
const int PATCH_VERSION = DERECHO_PATCH_VERSION;
const int COMMITS_AHEAD_OF_VERSION = DERECHO_COMMITS_AHEAD;

const char* VERSION_STRING = QUOTE(DERECHO_MAJOR_VERSION)
"."
QUOTE(DERECHO_MINOR_VERSION)
"."
QUOTE(DERECHO_PATCH_VERSION);
const char* VERSION_STRING_PLUS_COMMITS = QUOTE(DERECHO_MAJOR_VERSION)
"."
QUOTE(DERECHO_MINOR_VERSION)
"."
QUOTE(DERECHO_PATCH_VERSION)
"+"
QUOTE(DERECHO_COMMITS_AHEAD);
} // namespace derecho
13 changes: 5 additions & 8 deletions src/core/version_code.cpp
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
#include <derecho/core/detail/version_code.hpp>
#include <derecho/core/git_version.hpp>
#include <functional>

/** A simple hash-combine function to "mix" two hashcodes */
Expand All @@ -14,13 +15,9 @@ const uint64_t compiler = ISGNU | ((__GNUC__ << 16) + __GNUC_MINOR__);
const uint64_t compiler = ISCLANG | (__clang_major__ << 16) + __clang_minor__ );
#endif

// These next assume that this is Derecho release 0.9.0
// In practice GitHub should be managing the three numbers and we should use
// the feature that substitutes them into the text file here.
#define DERECHO_MAJOR 0L // Replace with a major number managed by GitHub
#define DERECHO_MINOR 9L // Replace with a minor version number managed by GitHub
#define DERECHO_PATCHLEVEL 0L // Replace with a patch version number managed by GitHub
#define DERECHO_VERSION ((((DERECHO_MAJOR << 16) + DERECHO_MINOR) << 32) + DERECHO_PATCHLEVEL)
const uint64_t derecho_version = ((((static_cast<uint64_t>(derecho::MAJOR_VERSION) << 16)
+ derecho::MINOR_VERSION) << 32)
+ derecho::COMMITS_AHEAD_OF_VERSION);

/*
* The following variables are for detection of Endian order for integers.
Expand Down Expand Up @@ -98,7 +95,7 @@ namespace derecho {
// This function combines all the measurements defined above, using the "mix" function
uint64_t version_hashcode() {
return mix(mix(mix(mix(mix(mix(mix(std::hash<uint64_t>()(compiler),
std::hash<uint64_t>()(DERECHO_VERSION)),
std::hash<uint64_t>()(derecho_version)),
*reinterpret_cast<uint16_t*>(&int16_array)),
*reinterpret_cast<uint32_t*>(&int32_array)),
*reinterpret_cast<uint64_t*>(&int64_array)),
Expand Down
Loading

0 comments on commit 27f0a99

Please sign in to comment.