Updated README and removed an erroneous assert #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The README section on configuration files was out-of-date, and still referred to the old "leader_ip" and "leader_port" options which no longer exist. I fixed it and added an explanation of the new "per-node config" feature (derecho_node.cfg), which was also missing. Also, I noticed while testing that an assert in persistence_manager could actually fail during correct behavior, because I misunderstood the invariants of persistence requests and persist() calls. It's possible for persisted_version to be less than the parameter version, if the parameter version corresponds to a null message (which does not create a log entry). When a persistence request is posted, the argument version is just the current version at the time the request was posted, not the latest non-null version; thus it's not true that persist() will always persist up to the persistence request's parameter version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The README section on configuration files was out-of-date, and still referred to the old "leader_ip" and "leader_port" options which no longer exist. I fixed it and added an explanation of the new "per-node config" feature (derecho_node.cfg), which was also missing.
Also, I noticed while testing that an assert in persistence_manager could actually fail during correct behavior, because I misunderstood the invariants of persistence requests and persist() calls. It's possible for persisted_version to be less than the parameter version, if the parameter version corresponds to a null message (which does not create a log entry). When a persistence request is posted, the argument version is just the current version at the time the request was posted, not the latest non-null version; thus it's not true that persist() will always persist up to the persistence request's parameter version.