Skip to content

Rework string expressions/casts #712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jengelh
Copy link
Contributor

@jengelh jengelh commented May 23, 2025

Pull Request Type

  • Build and Dependency changes

Description

Consolidate the somewhat ugly (const char *)expr.u8string().c_str() into a macro.

Checklist

  • I have tested my changes locally and verified that they work as intended.
  • I have reviewed the changes to ensure they do not introduce any unnecessary complexity or duplicate code.
  • I understand that by submitting this pull request, I am agreeing to license my contributions under the project's license.

@winterheart
Copy link
Collaborator

Hi.
.u8string().c_str() casts is mostly temporary workaround until we completely change all APIs to std::filesystem::path and switch (someday, I hope) to C++20 where we can use std::format for string operations. After this these casts will be redundant.

@jengelh
Copy link
Contributor Author

jengelh commented May 24, 2025

someday, I hope

Yeah and until that day, let's have nice things, shall we?

@jengelh
Copy link
Contributor Author

jengelh commented May 26, 2025

At the very least, merge up to a2c9ec8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants