fix for "expect subclass obj of 'AncestralGenome' bug" #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug causes fatal error when ancestral genome is also extant genome. Solved by overwriting extant genome with ancestral genome.
…he genome set and then backing up another level?
This reverts commit 9c4c4e1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed the ancestral genome bug (#7) by overwriting extant genomes that are ancestral with an ancestral genome. I don't know if this is the optimal solution, but seems to be an improvement, since you can at least run though the analysis without getting a fatal error. I believe I found another bug in def set_MRCA where it appears to go up two levels instead of one to find the most recent common ancestor.