New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add `all` `typeCheckingMode` option and disable warnings when `typeCheckingMode` is `off` #49

Merged

DetachHead merged 4 commits into main from all

Jan 25, 2024

Owner

DetachHead commented Jan 24, 2024 •

edited

Loading

DetachHead marked this pull request as draft

January 24, 2024 07:44

This comment has been minimized.

Sign in to view

DetachHead force-pushed the all branch from f0e62f5 to 13a5c1b Compare

January 24, 2024 10:10

This comment has been minimized.

Sign in to view

DetachHead force-pushed the all branch from 13a5c1b to 7ffd210 Compare

January 24, 2024 10:23

DetachHead marked this pull request as ready for review

January 24, 2024 10:24

DetachHead requested a review from KotlinIsland

January 24, 2024 10:24

DetachHead force-pushed the all branch from 7ffd210 to c14f3c2 Compare

January 24, 2024 10:26

This comment has been minimized.

Sign in to view

DetachHead force-pushed the all branch from 784bccb to 801329e Compare

January 24, 2024 10:42

This comment has been minimized.

Sign in to view

KotlinIsland reviewed

View reviewed changes

Collaborator

KotlinIsland left a comment

We could make all the default, but we might want baseline support first.

packages/pyright-internal/src/common/configOptions.ts Outdated Show resolved Hide resolved


          mention disabling python.languageServer in vscode config in the readme

23cc1dd

DetachHead force-pushed the all branch from 801329e to 006b69a Compare

January 25, 2024 03:12

This comment has been minimized.

Sign in to view

DetachHead force-pushed the all branch from 006b69a to 63b61d4 Compare

January 25, 2024 03:22

DetachHead changed the title ~~add all typeCheckingMode option~~ add all typeCheckingMode option and disable warnings when typeCheckingMode is off

This comment has been minimized.

Sign in to view

DetachHead force-pushed the all branch from 63b61d4 to 1510b1b Compare

January 25, 2024 03:31

This comment has been minimized.

Sign in to view

KotlinIsland approved these changes

View reviewed changes

packages/pyright-internal/src/common/commandLineOptions.ts Outdated Show resolved Hide resolved

DetachHead added 3 commits

January 25, 2024 14:00


          add "all" option for typeCheckingMode

77f7975


          readme improvements

d362469


          off means off (no means no!!!!!!!!)

516079c

DetachHead force-pushed the all branch from 1510b1b to 516079c Compare

January 25, 2024 04:01

Contributor

github-actions bot commented Jan 25, 2024

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

DetachHead merged commit 154e0d4 into main

10 checks passed

DetachHead deleted the all branch

January 25, 2024 04:11

DetachHead mentioned this pull request

defaults in the documentation are outdated #61

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet