Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improved narrowing of generics #745

Merged
merged 17 commits into from
Nov 23, 2024
Merged

improved narrowing of generics #745

merged 17 commits into from
Nov 23, 2024

Commits on Nov 20, 2024

  1. use a generic's bound when narrowing with isinstance if it's covari… 

    …ant, or `Never` if it's contravariant
    @DetachHead
    DetachHead committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    f697aa1 View commit details
    Browse the repository at this point in the history

  2. do the same with match statements

    @DetachHead
    DetachHead committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    8b53acf View commit details
    Browse the repository at this point in the history

  3. add tests for typevar narrowing changes

    @DetachHead
    DetachHead committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    9bc70e9 View commit details
    Browse the repository at this point in the history

  4. don't do the variance narrowing thing if the type was originally `Any… 

    …`/Unknown
    @DetachHead
    DetachHead committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    be80947 View commit details
    Browse the repository at this point in the history

  5. workaround for fake typevars in __init__ methods when determining w… 

    …hether to use variance to specialize type vars when narrowing
    @DetachHead
    DetachHead committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    875c90b View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2024

  1. add test for an issue with the new generic narrowing logic picked up … 

    …by the primer
    @DetachHead
    DetachHead committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    bce38d8 View commit details
    Browse the repository at this point in the history

  2. don't use bounds for narrowing generics when type param is known

    @beauxq @DetachHead
    beauxq authored and DetachHead committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    1a452ed View commit details
    Browse the repository at this point in the history

  3. remove parentheses

    @beauxq @DetachHead
    beauxq authored and DetachHead committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    4e893da View commit details
    Browse the repository at this point in the history

  4. fix comment

    @beauxq @DetachHead
    beauxq authored and DetachHead committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    4931ced View commit details
    Browse the repository at this point in the history

  5. remove leading space from docstrings in tests

    @DetachHead
    DetachHead committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    1695c7a View commit details
    Browse the repository at this point in the history

  6. narrow constraints to a union of all possible conditions

    @DetachHead
    DetachHead committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    d334e3e View commit details
    Browse the repository at this point in the history

  7. add improvedGenericNarrowing option to allow users to disable the n… 

    …ew functionality
    @DetachHead
    DetachHead committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    468c396 View commit details
    Browse the repository at this point in the history

  8. don't sync when running the docs npm script because the project takes… 

    … ages to build
    @DetachHead
    DetachHead committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    a2265df View commit details
    Browse the repository at this point in the history

  9. fix logic to determine whether to use generic bounds for narrowing wh… 

    …en the value being narrowed is a union
    @DetachHead
    DetachHead committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    b190ca2 View commit details
    Browse the repository at this point in the history

  10. rename improvedGenericNarrowing to be consistent with other similar… 

    … options
    @DetachHead
    DetachHead committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    04e71ae View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2024

  1. add documentation for strictGenericNarrowing

    @DetachHead
    DetachHead committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    7936e67 View commit details
    Browse the repository at this point in the history

  2. add more info links to all the new settings

    @DetachHead
    DetachHead committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    bc175fb View commit details
    Browse the repository at this point in the history