Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove incorrect diagnostic for invalid python identifier in dataclass field aliases and prevent them from appearing in completions #838

Merged
merged 4 commits into from
Nov 1, 2024
Merged

remove incorrect diagnostic for invalid python identifier in dataclass field aliases and prevent them from appearing in completions #838

merged 4 commits into from
Nov 1, 2024

Commits on Oct 31, 2024

  1. remove diagnostic for invalid python identifier in dataclass field al… 

    …ias names because it's allowed in pydantic
    @DetachHead
    DetachHead committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    29fa038 View commit details
    Browse the repository at this point in the history

  2. filter out invalid python identifiers from completions

    @DetachHead
    DetachHead committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    8e741a4 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2024

  1. add back jest.jestCommandLine config because it actaully is still n… 

    …eeded after all
    @DetachHead
    DetachHead committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    acada3a View commit details
    Browse the repository at this point in the history

  2. add completions test for dataclass field alias with invalid identifier

    @DetachHead
    DetachHead committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    dba73e9 View commit details
    Browse the repository at this point in the history