Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix strictGenericNarrowing causing false positive reportUnnecessaryIsInstance errors when narrowing Callable #909

Merged
merged 4 commits into from
Dec 1, 2024
Merged

fix strictGenericNarrowing causing false positive reportUnnecessaryIsInstance errors when narrowing Callable #909

merged 4 commits into from
Dec 1, 2024
+117 −10

Commits on Nov 27, 2024

  1. fix strictGenericNarrowing causing false positive `reportUnnecessar… 

    …yIsInstance` errors when narrowing `Callable`
    @DetachHead
    DetachHead committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    fcced9f View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2024

  1. add a hacky method to narrow Callable types while keeping the generics

    @DetachHead
    DetachHead committed Dec 1, 2024
    Configuration menu
    Copy the full SHA
    7163a9b View commit details
    Browse the repository at this point in the history

  2. fix type being narrowed to Never when the type in the isinstance … 

    …check is decorated with `@final`
    @DetachHead
    DetachHead committed Dec 1, 2024
    Configuration menu
    Copy the full SHA
    84a509b View commit details
    Browse the repository at this point in the history

  3. fix Callable narrowing hack incorrectly being used on TypeIs

    @DetachHead
    DetachHead committed Dec 1, 2024
    Configuration menu
    Copy the full SHA
    848af1e View commit details
    Browse the repository at this point in the history