synthesize: support for aarch64-linux #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulienMalka
force-pushed
the
kernel-aarch64
branch
from
bc3ac53 to
1d0e925
Compare
cole-h
reviewed
Nov 17, 2023
cole-h
reviewed
Nov 17, 2023
| @@ -112,7 +112,11 @@ impl BootSpecV1 { | |||
| err: e, | |||
| })?; | |||
|
|
|||
| let kernel_file = generation.join("kernel-modules/bzImage"); | |||
| let kernel_image_name = match system.as_str() { | |||
| "x86_64-linux" => "bzImage", | |||
There was a problem hiding this comment.
I wonder if this should also be i686-linux, but I imagine there are so few systems out there running that that we can revisit this later if someone notices it's broken.
There was a problem hiding this comment.
true, i686-linux should use bzImage too.
cole-h
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation for this is NixOS/nixpkgs#267985
Checklist
cargo buildcargo fmtcargo clippycargo test