Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop unnecessary per-PR builds #118

Merged
merged 1 commit into from
May 18, 2024
Merged

Stop unnecessary per-PR builds #118

merged 1 commit into from
May 18, 2024

Conversation

lucperkins
Copy link
Member

@lucperkins lucperkins commented May 18, 2024 •
edited
Loading

Right now, we're building artifacts as part of the Release PR workflow even when those artifacts aren't being uploaded (because the upload to s3 label isn't being applied). This moves the if statement up to the build job to keep that from happening.

@lucperkins lucperkins mentioned this pull request May 18, 2024
Merged
@lucperkins lucperkins merged commit 42a91dd into main May 18, 2024
11 checks passed
@lucperkins lucperkins deleted the stop-unnecessary-builds branch May 18, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamc grahamc grahamc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucperkins @grahamc