Skip to content

Commit

Permalink
comment cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
colemickens committed May 8, 2024
1 parent a4e58e3 commit 9b4b3f8
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 5 deletions.
4 changes: 0 additions & 4 deletions src/flakehub_auth_fake.rs
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,6 @@ pub async fn get_fake_bearer_token(
let client = reqwest::Client::new();

let mut claims = github_actions_oidc_claims::Claims::make_dummy();
// FIXME: we should probably fill in more of these claims.

// TODO(review): on the contrary, I think we should ditch this, and we should basically use forge_login-esque functionality for this going forward
// this would remove the entire need for the fake JWT server, since we are ourselves a JWT issuer
claims.aud = "flakehub-localhost".to_string();
claims.iss = jwt_issuer_uri.to_string();
claims.repository = repository.to_string();
Expand Down
1 change: 0 additions & 1 deletion src/git_context.rs
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ impl GitContext {
spdx_expression,
repo_topics: github_graphql_data_result.topics.clone(),
revision_info: RevisionInfo {
// TODO(colemickens): type coherency here... :/ (as is bad)
commit_count: Some(github_graphql_data_result.rev_count as usize),
revision: github_graphql_data_result.revision.clone(),
},
Expand Down

0 comments on commit 9b4b3f8

Please sign in to comment.