Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register flake output paths with FlakeHub #95

Merged
merged 5 commits into from
Nov 17, 2023

Conversation

edolstra
Copy link
Contributor

@edolstra edolstra commented Nov 6, 2023

This is disabled by default because 1) it might fail (e.g. if the flake uses IFD); and 2) it may be slower (since it requires evaluating the drvPath/outPaths of every flake output).

This is disabled by default because 1) it might fail (e.g. if the
flake uses IFD); and 2) it may be slower (since it requires evaluating
the drvPath/outPaths of every flake output).
@grahamc
Copy link
Member

grahamc commented Nov 6, 2023

it might fail (e.g. if the flake uses IFD)

this part is fine actually, since we already refuse IFD.

it may be slower (since it requires evaluating the drvPath/outPaths of every flake output).

This part is less fine, so let's keep it optional and explore options :).

action.yaml Outdated Show resolved Hide resolved
action.yaml Show resolved Hide resolved
@Hoverbear
Copy link
Contributor

Hoverbear commented Nov 10, 2023

Can confirm --include-output-paths is significantly slower on repos like nix-installer.

I was also unable to turn this feature on and have the nix-installer repo successfully push.

@Hoverbear
Copy link
Contributor

I was able to successfully push a smaller crate.

Copy link
Contributor

@Hoverbear Hoverbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a minor stylistic nit

@edolstra edolstra enabled auto-merge November 17, 2023 15:07
@edolstra edolstra merged commit ee6c7aa into main Nov 17, 2023
5 checks passed
@edolstra edolstra deleted the edolstra/fh-1-upload-output-paths branch November 17, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants