Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chgrp existing store if GID is different #1330

Merged
merged 5 commits into from
Dec 2, 2024
Merged

chgrp existing store if GID is different #1330

merged 5 commits into from
Dec 2, 2024

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Dec 2, 2024

…-user-group.

Description
Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

@grahamc grahamc requested a review from cole-h December 2, 2024 22:22
cole-h
cole-h approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes me feel funky, but...

If it causes issues, we'll revisit.

@cole-h cole-h enabled auto-merge (squash) December 2, 2024 23:03
@cole-h cole-h changed the title After unpacking Nix, regrp the store if its group isn't the new build… chgrp existing store if GID is different Dec 2, 2024
@cole-h cole-h merged commit ac5e8c0 into main Dec 2, 2024
21 checks passed
@cole-h cole-h deleted the graham/fh-478-creating-a-nixbld-group-with-gid-0-isnt-right branch December 2, 2024 23:15
@cole-h cole-h added this to the 0.31.0 milestone Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h cole-h approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.31.0
Development

Successfully merging this pull request may close these issues.
2 participants
@grahamc @cole-h