Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ssl-cert-file config #527

Conversation

Hoverbear
Copy link
Contributor

@Hoverbear Hoverbear commented Jun 23, 2023

Description

Fixes #516, uses NixOS/nix#8062

Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

@Hoverbear Hoverbear added this to the 0.9.2 milestone Jun 23, 2023
@Hoverbear Hoverbear self-assigned this Jun 23, 2023
@Hoverbear Hoverbear requested a review from cole-h June 23, 2023 21:16
@Hoverbear
Copy link
Contributor Author

I noticed while testing that if I deleted the ssl file before uninstall, that uninstalling could get a bit janky. I want to explore a bit more.

@cole-h
Copy link
Member

cole-h commented Jun 23, 2023

Could we just ignore a missing file ("if they removed it, less work for us")?

@Hoverbear
Copy link
Contributor Author

Yeah I worked around the issue I had but I want to make sure there aren't more :)

@Hoverbear
Copy link
Contributor Author

Ok that works!

@Hoverbear Hoverbear marked this pull request as ready for review June 26, 2023 16:57
@Hoverbear Hoverbear merged commit 4bfd6c2 into main Jun 26, 2023
@Hoverbear Hoverbear deleted the hoverbear/ds-973-prevent-future-macos-breakage-on-gha-with-ssl-cert-file branch June 26, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

potential upcoming macOS breakage around launchctl setenv
2 participants