Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support user-defined diagnostics attribution #635

Merged
merged 3 commits into from
Sep 20, 2023
Merged

Support user-defined diagnostics attribution #635

merged 3 commits into from
Sep 20, 2023

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Sep 19, 2023 •
edited
Loading

Description
Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

@grahamc
Switch to flakehub
3961e46
@grahamc
Diagnostics: support user-defined attribution.
90b5543 
Allows a user to specify an additional value to associate their diagnostics with that value. nix-installer doesn't generate or store these values, and most users have no need for it.
@grahamc grahamc added the upload to s3 The labeled PR is allowed to upload its artifacts to S3 for easy testing label Sep 19, 2023
@grahamc
Copy link
Member Author

grahamc commented Sep 19, 2023

Just checked how this goes, and it works correctly. By default, the attribution field is not set, but if set ahead of time it is set and shared through to diagnostics.

@grahamc grahamc requested review from Hoverbear and cole-h September 19, 2023 21:12
@grahamc grahamc modified the milestones: 0.11.0, 0.11.1 Sep 20, 2023
Hoverbear
Hoverbear suggested changes Sep 20, 2023
View reviewed changes
src/settings.rs Outdated Show resolved Hide resolved
src/settings.rs Outdated Show resolved Hide resolved
src/settings.rs Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@grahamc grahamc requested a review from Hoverbear September 20, 2023 16:09
grahamc
grahamc commented Sep 20, 2023
View reviewed changes
src/settings.rs
Comment on lines +338 to +339
#[cfg(feature = "diagnostics")]
diagnostic_attribution: _,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rust-lang/rustfmt#5920

@Hoverbear Hoverbear merged commit 60e5fff into main Sep 20, 2023
@Hoverbear Hoverbear deleted the attribution branch September 20, 2023 18:23
This was referenced May 23, 2024
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hoverbear Hoverbear Hoverbear approved these changes

@cole-h cole-h Awaiting requested review from cole-h

Assignees
No one assigned
Labels
upload to s3 The labeled PR is allowed to upload its artifacts to S3 for easy testing
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@grahamc @Hoverbear