Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reintroduce 640, 638, 627 #651

Merged
merged 3 commits into from
Sep 28, 2023
Merged

Reintroduce 640, 638, 627 #651

merged 3 commits into from
Sep 28, 2023

Conversation

Hoverbear
Copy link
Contributor

Description

Reverting #648 also reverted #640, #638, #627.

Reintroduce them.

Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

@Hoverbear Hoverbear added this to the 0.12.1 milestone Sep 28, 2023
@Hoverbear Hoverbear self-assigned this Sep 28, 2023
@Hoverbear Hoverbear enabled auto-merge (squash) September 28, 2023 22:17
@Hoverbear Hoverbear disabled auto-merge September 28, 2023 22:17
@Hoverbear Hoverbear enabled auto-merge (squash) September 28, 2023 22:37
@Hoverbear Hoverbear mentioned this pull request Sep 28, 2023
Merged
6 tasks
@Hoverbear Hoverbear merged commit 042873d into main Sep 28, 2023
5 checks passed
@Hoverbear Hoverbear deleted the reintroduce-640-638-627 branch September 28, 2023 22:58
This was referenced May 23, 2024
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h cole-h approved these changes

Assignees

@Hoverbear Hoverbear

Labels
None yet
Projects
None yet
Milestone
0.13.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Hoverbear @cole-h