Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't include the version number in the nix config, for reproducibility #710

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Nov 8, 2023

I just installed Nix about a hundred times, and got the same hash for the config every time. This was largely because we updated the nix-config-parser crate to use an ordered HashMap, instead of the regular HashMap. The remaining variability in here will be from the version number in the comment, and any custom configuration the user has specified. This PR fixes that :).

Closes #562
Closes #580

Description
Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

@grahamc grahamc force-pushed the grahamc/580-repro-nix-conf branch from d5fb9b7 to 035a30c Compare November 8, 2023 18:39
@grahamc grahamc requested a review from Hoverbear November 8, 2023 18:48
@grahamc grahamc changed the title Don't include the version number in the nix config, for reproducibili… Don't include the version number in the nix config, for reproducibility Nov 8, 2023
@Hoverbear Hoverbear enabled auto-merge (squash) November 8, 2023 18:52
@Hoverbear Hoverbear merged commit a026cc2 into main Nov 8, 2023
5 checks passed
@Hoverbear Hoverbear deleted the grahamc/580-repro-nix-conf branch November 8, 2023 19:00
@Hoverbear Hoverbear added this to the 0.14.1 milestone Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nix-darwin install Generated nix.conf is not deterministic
2 participants