Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experiment with compiling a tarball in to the executable #723

Closed
wants to merge 6 commits into from
Closed

Experiment with compiling a tarball in to the executable #723

wants to merge 6 commits into from

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Nov 12, 2023

Description

I'm not sure it is a good idea, because it actually takes longer in my macOS UTM VM. However, I wonder how long it'll take in GHA...

Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

@grahamc
Remove the writable flag, don't set too many permission bits
d17c1b4 
Making everything 0o555 is too much, since many files in the store
are not supposed to be executable. Those should be 0o444. Instead
of splatting 0o555 out, take a more measured approach and remove
the writable flag from the on-disk mode.
@grahamc
Nix config: add extra newlines after the initial comment
c2d7059 
Otherwise the extra-config option will get swallowed.

Closes #717
@grahamc
Push individual strs
60d19b2
@grahamc
Merge branch 'close/717' into bundled
47c49cc
@grahamc
Compile in a tarball
abd6c30
@grahamc grahamc added the upload to s3 The labeled PR is allowed to upload its artifacts to S3 for easy testing label Nov 12, 2023
@grahamc grahamc mentioned this pull request Nov 14, 2023
Open
@Hoverbear
Copy link
Contributor

We'll probably need to do some profiling to figure out why it is slower....

@grahamc grahamc closed this Nov 17, 2023
@grahamc grahamc deleted the bundled branch November 17, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
upload to s3 The labeled PR is allowed to upload its artifacts to S3 for easy testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grahamc @Hoverbear