-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multiple flake directories #109
base: main
Are you sure you want to change the base?
Conversation
@DavHau If you could give this a try in one of your repos, that would be great! - uses: DeterminateSystems/update-flake-lock@multiple-flake-dirs-ts |
Thanks for this. Will test it tomorrow |
I've tested this out in an external repo: https://github.com/lucperkins/update-flake-lock-multiple-dirs This run successfully created this PR (with sub-dirs There were two unsuccessful runs of the same workflow but that was solely related to improper permissions on the test repo. Changing the permissions resolved the issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to your test run, functionality seems to work just fine, but I'm a bit worried about UX.
- The PR body only lists one of the updated flake.locks.
- I'd expect it to either list all of them, or none of them.
- The commit messages are all just
flake.lock: Update
, butflake.lock
is only updated once -- the others that are updated aresubflake1/flake.lock
andsubflake2/flake.lock
. However, if I manually put aflake.nix
andflake.lock
in some subdir in a local repo of mine and runnix flake update --commit-lock-file
, it correctly commits it assubdir/flake.lock: Update
@cole-h The root Update: okay, I see now that we have some flexibility with the templating so I'll update the |
Yes, I know the root flake.lock is only updated once. However, if you look at your PR, the commit messages all say Whereas using This doesn't strike me as good UX, not being able to distinguish between which commit updated which flake.lock.... |
We like the idea behind #98 but unfortunately we switched this Action to use JS instead of Bash, which means that implementing that would be a non-trivial amount of work for @DavHau so I've decided to go ahead and implement it on my own (given that I know our internal libs well).