-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚀 enhancement: Added Buttons in the whiteboard header to allow the user to increase or decrease the font size #204
base: main
Are you sure you want to change the base?
Conversation
…nd presentation mode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm so far – just a question about deleted docs and I need to test it locally still... But besides, looks very nice! Thanks for your great work!
…nd presentation mode
e5bf4e2
to
a92d0e5
Compare
Hey @ahsanfarooq210, I just did some local testing and it does not seem to work quite yet. I am trying to figure out if its my local setup or the code not working. I assume you did test the functionality and it worked for you? I am still very busy with other projects, so please bear with me until I can dig deeper into the problem. Sorry about that! |
Hi @TadeSF. I have pushed the changes. one of the commits was not pushed on Git Hub, I tried to check in the commit but Git was giving me an error. i have implemented the code for that commit again. can you give it one more try? |
Hey @ahsanfarooq210, Only one thing: There seems to be some merge-hickup since you revert this PR in the changes. But thats something I am happy to sort out myself. Should be a quick fix ;) We are currently working on a registration app for our participants over at this repo, but we will come back to this project timely in the new year to prepare it for our next conference in march. Just so you have an understanding what is happening if you want to continue contributing and were wondering why it all became so quiet. Not at all a dead project, just on small pause for priority reasons ;) |
Added buttons in the whiteboard component to increase or decrease the font size.
the default font size is 18 px and the user can change it between 28 px (max) and 12 px(min). This has been implemented both in the dashboard and in the presentation mode.
#176