Skip to content

Commit

Permalink
Merge pull request #28 from DevExpress/parsing_negative_numbers
Browse files Browse the repository at this point in the history
Fix parsing negative numbers
nightskylark authored Sep 25, 2017

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
2 parents 51a053a + fb0927d commit 3b01b2d
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/number.js
Original file line number Diff line number Diff line change
@@ -96,7 +96,7 @@ numberLocalization.inject({
}

var decimalSeparator = this._getDecimalSeparator(format);
var cleanUpRegexp = new RegExp('[^0-9\\' + decimalSeparator + ']', 'g');
var cleanUpRegexp = new RegExp('[^0-9\-\\' + decimalSeparator + ']', 'g');

return text.replace(cleanUpRegexp, '').replace(decimalSeparator, legitDecimalSeparator);
},
1 change: 1 addition & 0 deletions tests/number-tests.js
Original file line number Diff line number Diff line change
@@ -133,6 +133,7 @@ require('../src/number');
assert.equal(numberLocalization.parse(getIntlFormatter({ maximumFractionDigits: 0, minimumFractionDigits: 0 })(437)), 437);
assert.equal(numberLocalization.parse(getIntlFormatter({ maximumFractionDigits: 1, minimumFractionDigits: 1 })(1.2)), 1.2);
assert.equal(numberLocalization.parse(getIntlFormatter({ maximumFractionDigits: 0, minimumFractionDigits: 0 })(12000)), 12000);
assert.equal(numberLocalization.parse(getIntlFormatter({ maximumFractionDigits: 0, minimumFractionDigits: 0 })(-10)), -10);

assert.equal(numberLocalization.parse(getIntlFormatter({ style: 'currency', currency: 'USD', minimumFractionDigits: 1 })(1.2)), 1.2);
});

0 comments on commit 3b01b2d

Please sign in to comment.