Chat: Add showDayHeader, showAvatar, showMessageTimestamp, showUserName properties in d.ts #28219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…24_2-add-chat-properties-d.ts
|
Changed files look strange. A lot has been removed from them, which I suppose is a mistake. It seems to be the reason for the failed tests in CI tests. Kindly check it |
This reverts commit 6b9fe87.
…24_2-add-chat-properties-d.ts
EugeniyKiyashko
previously approved these changes
Oct 23, 2024
ksercs
reviewed
Oct 23, 2024
|
@nikkithelegendarypokemonster kindly make PR name more precise |
vladaskorohodova
previously approved these changes
Oct 24, 2024
ksercs
previously approved these changes
Oct 24, 2024
nikkithelegendarypokemonster
changed the title
nikkithelegendarypokemonster
changed the title
Signed-off-by: EugeniyKiyashko <[email protected]>
EugeniyKiyashko
dismissed stale reviews from vladaskorohodova and themself
via
12693f1
EugeniyKiyashko
requested review from
EugeniyKiyashko,
vladaskorohodova and
ksercs
vladaskorohodova
previously approved these changes
Oct 25, 2024
ksercs
previously approved these changes
Oct 25, 2024
EugeniyKiyashko
previously approved these changes
Oct 25, 2024
marker-dao
previously approved these changes
Oct 28, 2024
…24_2-add-chat-properties-d.ts # Conflicts: # packages/devextreme/js/__internal/ui/chat/chat.ts # packages/devextreme/js/ui/chat.d.ts
nikkithelegendarypokemonster
dismissed stale reviews from marker-dao, EugeniyKiyashko, ksercs, and vladaskorohodova
via
b25bfce
nikkithelegendarypokemonster
requested review from
EugeniyKiyashko,
marker-dao,
vladaskorohodova and
ksercs
ksercs
reviewed
Oct 28, 2024
EugeniyKiyashko
approved these changes
Oct 28, 2024
vladaskorohodova
approved these changes
Oct 29, 2024
ksercs
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.