Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Eslint to 9 version #28951

Open
wants to merge 9 commits into
base: 25_1
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 1 addition & 46 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,51 +16,6 @@ env:
NX_SKIP_NX_CACHE: ${{ (github.event_name != 'pull_request' || contains( github.event.pull_request.labels.*.name, 'skip-cache')) && 'true' || 'false' }}

jobs:
Renovation:
Alyar666 marked this conversation as resolved.
Show resolved Hide resolved
runs-on: devextreme-shr2
timeout-minutes: 60
steps:
- name: Get sources
uses: actions/checkout@v4

- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: '20'

- uses: pnpm/action-setup@v3
with:
version: 9
run_install: false

- name: Get pnpm store directory
shell: bash
run: |
echo "STORE_PATH=$(pnpm store path --silent)" >> $GITHUB_ENV

- uses: actions/cache@v4
name: Setup pnpm cache
with:
path: |
${{ env.STORE_PATH }}
.nx/cache
key: ${{ runner.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
restore-keys: |
${{ runner.os }}-pnpm-store

- name: Install dependencies
run: pnpm install

- name: Compile renovation
working-directory: ./packages/devextreme
run: |
pnpx nx compile:r
# Remove package install after upgrade to TypeScript >= 4.6

- name: Lint renovation
working-directory: ./packages/devextreme
run: pnpx nx lint-renovation

TS:
runs-on: devextreme-shr2
timeout-minutes: 60
Expand Down Expand Up @@ -380,7 +335,7 @@ jobs:
notify:
runs-on: devextreme-shr2
name: Send notifications
needs: [Renovation, TS, JS, CSS, texts, pnpm_lock, component_exports]
needs: [TS, JS, CSS, texts, pnpm_lock, component_exports]
if: github.event_name != 'pull_request' && contains(needs.*.result, 'failure')

steps:
Expand Down
3 changes: 1 addition & 2 deletions .lintstagedrc
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
{
"**/*.{css,scss}": "stylelint",
"packages/devextreme/**/*.{js,ts,tsx}": "eslint --quiet"
"**/*.{css,scss}": "stylelint"
}
15 changes: 0 additions & 15 deletions packages/devextreme/.eslintignore

This file was deleted.

163 changes: 0 additions & 163 deletions packages/devextreme/.eslintrc.js

This file was deleted.

3 changes: 3 additions & 0 deletions packages/devextreme/.lintstagedrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"**/*.{js,ts,tsx}": "eslint --quiet"
}
25 changes: 0 additions & 25 deletions packages/devextreme/build/.eslintrc.js

This file was deleted.

Loading
Loading