Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fluent theme by default #900

Draft
wants to merge 10 commits into
base: dev
Choose a base branch
from
9 changes: 3 additions & 6 deletions packages/devextreme-cli/src/commands.json
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
"description": "Specifies base theme name (default value is generic.light)"
}, {
"name": "--input-file",
"description": "Specifies file name with input data (a .json file with metadata or a .less/.scss file with Bootstrap variables)"
"description": "Specifies file name with input data (a .json file with metadata or a .scss file with Bootstrap 5 variables)"
}, {
"name": "--make-swatch",
"description": "If present, adds a CSS scope to each CSS rule (.dx-swatch-xxx), where xxx is the value from the --output-color-scheme parameter"
Expand All @@ -76,9 +76,6 @@
}, {
"name": "--remove-external-resources",
"description": "When present, removes links to external resources, such as fonts. The theme will use local fallbacks instead. Available from DevExtreme v20.2.7."
}, {
"name": "--bootstrap-version",
"description": "Specifies Bootstrap version 4 or 5 if '--input-file' is a '.scss' file. Available from DevExtreme v21.1.5. Default value: 4."
}]
}, {
"name": "export-theme-vars",
Expand All @@ -89,7 +86,7 @@
"description": "Specifies base theme name (default value is generic.light)"
}, {
"name": "--input-file",
"description": "Specifies file name with input data (a .json file with metadata or a .less/.scss file with Bootstrap variables)"
"description": "Specifies file name with input data (a .json file with metadata or a .scss file with Bootstrap 5 variables)"
}, {
"name": "--output-format",
"description": "Specifies the format of output variables (less or scss) (default value is less or the extension extracted from the --output-file value (if it contains any))"
Expand All @@ -112,7 +109,7 @@
"description": "Specifies base theme name (default value is generic.light)"
}, {
"name": "--input-file",
"description": "Specifies file name with input data (a .json file with metadata or a .less/.scss file with Bootstrap variables)"
"description": "Specifies file name with input data (a .json file with metadata or a .scss file with Bootstrap 5 variables)"
}, {
"name": "--output-file",
"description": "Specifies output file name"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
@import "../../dx-styles.scss";
@import "../../themes/generated/variables.additional.scss";

.side-navigation-menu {
div.dx-swatch-additional.side-navigation-menu {
display: flex;
flex-direction: column;
min-height: 100%;
height: 100%;
width: 250px !important;
background-color: $base-bg;

.menu-container {
min-height: 100%;
Expand All @@ -22,6 +23,7 @@
.dx-treeview-item {
padding-left: 0;
flex-direction: row-reverse;
border-radius: 0;

.dx-icon {
width: $side-panel-min-width !important;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -100,3 +100,9 @@ html, body {
* {
box-sizing: border-box;
}

.dx-theme-fluent {
.dx-drawer-panel-content {
box-shadow: 0 4px 4px rgba(0, 0, 0, 0.12);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
#navigation-header {
@import "../../themes/generated/variables.additional.scss";
box-shadow: 0 1px 3px rgba(0, 0, 0, 0.12), 0 1px 2px rgba(0, 0, 0, 0.24);
background-color: $base-bg;

.screen-x-small & {
padding-left: 20px;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"items": [],
"baseTheme": "material.blue.light",
"baseTheme": "fluent.blue.light",
"assetsBasePath": "../../../node_modules/devextreme/dist/css/",
"outputColorScheme": "additional",
"makeSwatch": true,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"items": [],
"baseTheme": "material.blue.light",
"baseTheme": "fluent.blue.light",
"assetsBasePath": "../../../node_modules/devextreme/dist/css/",
"outputColorScheme": "base",
"base": true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -111,12 +111,13 @@ export default {
@import "../dx-styles.scss";
@import "../themes/generated/variables.additional.scss";

.side-navigation-menu {
div.dx-swatch-additional.side-navigation-menu {
display: flex;
flex-direction: column;
min-height: 100%;
height: 100%;
width: 250px !important;
background-color: $base-bg;

.menu-container {
min-height: 100%;
Expand All @@ -132,6 +133,7 @@ export default {
.dx-treeview-item {
padding-left: 0;
flex-direction: row-reverse;
border-radius: 0;

.dx-icon {
width: $side-panel-min-width !important;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,3 +64,9 @@
}

$side-panel-min-width: 60px;

.dx-theme-fluent {
.dx-drawer-panel-content {
box-shadow: 0 4px 4px rgba(0, 0, 0, 0.12);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,7 @@ export default {
#navigation-header {
@import "../themes/generated/variables.additional.scss";
box-shadow: 0 1px 3px rgba(0, 0, 0, 0.12), 0 1px 2px rgba(0, 0, 0, 0.24);
background-color: $base-bg;

.screen-x-small & {
padding-left: 20px;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"items": [],
"baseTheme": "material.blue.light",
"baseTheme": "fluent.blue.light",
"assetsBasePath": "../../../node_modules/devextreme/dist/css/",
"outputColorScheme": "additional",
"makeSwatch": true,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"items": [],
"baseTheme": "material.blue.light",
"baseTheme": "fluent.blue.light",
"assetsBasePath": "../../../node_modules/devextreme/dist/css/",
"outputColorScheme": "base",
"base": true
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 2 additions & 1 deletion packages/devextreme-cli/testing/constants.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@ exports.viewports = {

exports.themes = {
material: 'material.blue',
generic: 'generic'
generic: 'generic',
fluent: 'fluent.blue'
};

exports.layouts = [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
#navigation-header {
@import "../../../themes/generated/variables.additional.scss";
box-shadow: 0 1px 3px rgba(0, 0, 0, 0.12), 0 1px 2px rgba(0, 0, 0, 0.24);
background-color: $base-bg;

:host-context(.screen-x-small) & {
padding-left: 20px;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
@import "../../../../dx-styles.scss";
@import "../../../../themes/generated/variables.additional.scss";

:host {
:host.dx-swatch-additional {
display: flex;
flex-direction: column;
min-height: 100%;
height: 100%;
width: 250px !important;
background-color: $base-bg;

.menu-container {
min-height: 100%;
Expand All @@ -22,6 +23,7 @@
.dx-treeview-item {
padding-left: 0;
flex-direction: row-reverse;
border-radius: 0;

.dx-icon {
width: $side-panel-min-width !important;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,3 +70,9 @@ html, body {
}

$side-panel-min-width: 60px;

.dx-theme-fluent {
.dx-drawer-panel-content {
box-shadow: 0 4px 4px rgba(0, 0, 0, 0.12);
}
}
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"items": [],
"baseTheme": "material.blue.light",
"baseTheme": "fluent.blue.light",
"assetsBasePath": "<%= path %>../../node_modules/devextreme/dist/css/",
"outputColorScheme": "additional",
"makeSwatch": true,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"items": [],
"baseTheme": "material.blue.light",
"baseTheme": "fluent.blue.light",
"assetsBasePath": "<%= path %>../../node_modules/devextreme/dist/css/",
"outputColorScheme": "base",
"base": true
Expand Down
Loading