Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add protocol argument to browser-proxy, allowing run using https for … #213

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

PavelMor25
Copy link
Contributor

…Android devices (#211)

  • Included the target protocol in the browser proxy, which is used when run in an Android device and fixed the test that validate the common browsers with a not existing iPhone version

  • Update the Iphone SE test case name for the browser-names-test.js 'Should validate browser names'

  • Removing comments from the browser-names-test.js


…Android devices (#211)

* Included the target protocol in the browser proxy, which is used when run in an Android device and fixed the test that validate the common browsers with a not existing iPhone version

* Update the Iphone SE test case name for the browser-names-test.js 'Should validate browser names'

* Removing comments from the browser-names-test.js

---------

Co-authored-by: MarceloArraes <[email protected]>
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@PavelMor25 PavelMor25 merged commit 5b9a1ee into dependabot/npm_and_yarn/sharp-0.32.6 Dec 28, 2023
8 checks passed
PavelMor25 added a commit that referenced this pull request Dec 28, 2023
* build(deps): bump sharp from 0.30.7 to 0.32.6

Bumps [sharp](https://github.com/lovell/sharp) from 0.30.7 to 0.32.6.
- [Release notes](https://github.com/lovell/sharp/releases)
- [Changelog](https://github.com/lovell/sharp/blob/main/docs/changelog.md)
- [Commits](lovell/sharp@v0.30.7...v0.32.6)

---
updated-dependencies:
- dependency-name: sharp
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

* Add protocol argument to browser-proxy, allowing run using https for Android devices (#211) (#213)

* Included the target protocol in the browser proxy, which is used when run in an Android device and fixed the test that validate the common browsers with a not existing iPhone version

* Update the Iphone SE test case name for the browser-names-test.js 'Should validate browser names'

* Removing comments from the browser-names-test.js

---------

Co-authored-by: Marcelo Arraes <[email protected]>
Co-authored-by: MarceloArraes <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: PavelMor25 <[email protected]>
Co-authored-by: Marcelo Arraes <[email protected]>
Co-authored-by: MarceloArraes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants