Fix header height on safari

[JHKennedy4]

Is there a workaround for loading jQuery locally? I can't get the animated header to work and I'd like to be sure I didn't break it with this change.

[Eyas]

Thanks for the change. Would you be able to amend this commit so as not to include anything in docs/. Our master branch is mirrored to the live site (we didn't put much time in a proper release process) so we process "build" commits separately as prod pushes.

Also, as a side note, you accidentally committed a delete of the CNAME folder in docs/. Jekyll does that automatically which is not good, but we actually need it there as well.

For testing with jQuery locally, did you run this using jekyll serve? I think jQuery should load locally just fine if served through http:// in general (e.g. 127.0.0.1 or localhost), but will fail if served through file:///.

Finally, I remember needing to put display: flex; for some browser. MS Edge perhaps. Make sure to test on Chrome, Firefox, etc., but afterwards I can test it from your branch locally to make sure.

[JHKennedy4]

Should I put the contents of docs/ in .gitignore? I'm running with bundle exec jekyll serve and I'm getting a crossDomain error loading jQuery. I've tested locally on Safari, Chrome, and Firefox. Don't have Edge to test on.

I'm curious what it'll impact. I was a bit surprised to see the display: flex; on the body, it should work fine without it, but I'll find another solution if it causes problems.

[Eyas]

We haven't perfected this yet, but for the time being, docs/ shouldn't be gitignored. Ideally we'd have a master branch where their ignored and a publish branch where they aren't. But since the live site's content is actually mirrored from docs/, and "build commits" actually modify docs/, we've so far just settled for not git adding these for "source change" commits.

[JHKennedy4]

Got it, on a quick errand, but I'll revert the files changed and push them
up.
On Sun, Oct 30, 2016 at 3:48 PM Eyas [email protected] wrote:

We haven't perfected this yet, but for the time being, docs/ shouldn't be
gitignored. Ideally we'd have a master branch where their ignored and a
publish branch where they aren't. But since the live site's content is
actually mirrored from docs/, and "build commits" actually modify docs/,
we've so far just settled for not git adding these for "source change"
commits.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#174 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAJv5-3bVcyYqQv7LcvgJALX6Bj7Xv-Qks5q5R62gaJpZM4Kkhks
.

[Eyas]

I'm trying this locally, but it seems that the result in latest Chrome is that pages don't scroll at all..