Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded to .NET 8 and replaced deprecated NuGet packages #982

Merged
merged 20 commits into from
Nov 19, 2023

Conversation

samsmithnz
Copy link
Collaborator

@samsmithnz samsmithnz commented Nov 19, 2023

This pull request includes a wide range of changes across multiple files in the project to:

  • Upgrade projects to .NET 8
  • Replaced two deprecated packages for Azure Tables + Azure Key Vault
  • Removed the Probot component now that Probot is no longer maintained

Main functionality changes:

  • src/DevOpsMetrics.Cmd/Program.cs: Added conditional logic for configuring Azure Key Vault and updated using statements. [1] [2]
  • src/DevOpsMetrics.Function/NightlyProcessor.cs: Added conditional logic for configuring Azure Key Vault and updated using statements. [1] [2]
  • src/DevOpsMetrics.Service/Program.cs: Updated using statements and modified code to load Azure Key Vault URL from the configuration file. [1] [2]

Package and framework updates:

  • src/DevOpsMetrics.Tests/DevOpsMetrics.Tests.csproj: Modified package versions, added new package references, and updated target framework to net8.0. [1] [2]
  • src/DevOpsMetrics.Function/DevOpsMetrics.Function.csproj: Updated package versions, added new package references, and updated target framework to net8.0.
  • src/DevOpsMetrics.Cmd/DevOpsMetrics.Cmd.csproj: Added new package references and updated target framework. [1] [2]
  • src/DevOpsMetrics.Web/DevOpsMetrics.Web.csproj: Updated target framework to net8.0.
  • src/DevOpsMetrics.Core/DevOpsMetrics.Core.csproj: Updated target framework versions from net6.0;net7.0 to net6.0;net8.0.
  • src/DevOpsMetrics.FunctionalTests/DevOpsMetrics.FunctionalTests.csproj: Updated target framework version from net7.0 to net8.0.
  • src/DevOpsMetrics.Service/DevOpsMetrics.Service.csproj: Updated target framework version from net7.0 to net8.0.

Other important changes:

  • README.md: Updated various sections of the README file, including project status, badge descriptions, and added links to a demo website and a blog post. [1] [2] [3] [4] [5]
  • .github/workflows/dotnetcore.yml: Updated dotnet-version and path to chromedriver.exe file in workflow configurations. [1] [2] [3] [4] [5]
  • .github/workflows/codeql-analysis.yml: Updated dotnet-version in the workflow configuration.
  • .github/dependabot.yml: Removed commented out configuration for updating dependencies.
  • src/DevOpsMetrics.sln: Removed the DevOpsMetrics.Function project from the solution file.
  • GitVersion.yml: Updated next-version to '1.10.0'.
  • src/DevOpsMetrics.Tests/BaseConfiguration.cs: Added new using statements and updated the TestStartUp method to handle Azure Key Vault configuration. [1] [2]
  • src/DevOpsMetrics.Service/appsettings.json: Added a new property called "TenantId" to the "AppSettings" section.
  • src/DevOpsMetrics.Tests/appsettings.json: Added TenantId property with value "40244aae-8aee-4af5-b221-b480db24698b".

@coveralls
Copy link

coveralls commented Nov 19, 2023

Pull Request Test Coverage Report for Build 6918027457

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 77.572%

Totals Coverage Status
Change from base Build 6763108912: -0.03%
Covered Lines: 2620
Relevant Lines: 3321

💛 - Coveralls

@samsmithnz samsmithnz merged commit 88558a3 into main Nov 19, 2023
10 checks passed
@samsmithnz samsmithnz deleted the UpgradeToDotNet8 branch November 19, 2023 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants