Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scripts for test database setup #398

Merged
merged 4 commits into from
Mar 21, 2023

Conversation

Eakam1007
Copy link
Contributor

Based on #350 (comment), the following changes have been made:

  • Add setup:test script to setup the test database
  • Add db:studio:test script to view the test database using prisma studio
  • Change db.server.ts to prioritize the value of DATABASE_URL in process.env over the value in secrets for development/testing environments. This is required so that the tests run using the test database since we override the value in process.env in the test scripts
  • Update CONTRIBUTING.md to include information about the new scripts

@Eakam1007 Eakam1007 added category: testing Unit tests, end to end tests area: devOps Services/tools that are not our main functionality, but help the project labels Mar 21, 2023
@Eakam1007 Eakam1007 added this to the Milestone 0.7 milestone Mar 21, 2023
@Eakam1007 Eakam1007 requested review from humphd and cychu42 March 21, 2023 00:34
@Eakam1007 Eakam1007 self-assigned this Mar 21, 2023
@Eakam1007 Eakam1007 merged commit ff7a600 into DevelopingSpace:main Mar 21, 2023
@Eakam1007 Eakam1007 deleted the add-test-data-setup-script branch March 21, 2023 17:19
@cychu42
Copy link
Contributor

cychu42 commented Mar 22, 2023

I just want to say it LGTM for the record. Nice work taking care of the CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: devOps Services/tools that are not our main functionality, but help the project category: testing Unit tests, end to end tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants