Improve the functionality and maintainability of the codebase #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sylfwood
force-pushed
the
devops/features
branch
from
7ca7ade to
feda502
Compare
DannyBedard
reviewed
Mar 24, 2025
| @@ -30,11 +30,11 @@ | |||
|
|
|||
| EXAMPLES = r""" | |||
| - name: Fetch dvls server information | |||
| server: | |||
| devolutions.dvls.fetch_server: | |||
There was a problem hiding this comment.
Je ne crois pas que ça marcherait, si c'est le cas ce serait breaking
There was a problem hiding this comment.
C'est le sanity check qui m'a montré ca! C'est pour que l'exemple de la doc suive comme du monde le code. Si je me fais au playbouk, c'est de même qu'on le fait. Donc l'exemple est bonne.
|
|
||
|
|
||
| def run_module(): | ||
| module_args = dict( | ||
| argument_spec = dict( |
There was a problem hiding this comment.
Je le changerait sur les autres aussi rendu là
| module = AnsibleModule(argument_spec=module_args, supports_check_mode=True) | ||
| module = AnsibleModule(argument_spec=argument_spec, supports_check_mode=True) | ||
|
|
||
| if not HAS_REQUESTS_LIBRARY: |
There was a problem hiding this comment.
Est-ce qu'on peut ajouter cette condition dans les autres modules aussi?
There was a problem hiding this comment.
C'est seulement pertinent pour les libs externes, dans ce cas-ci, celle qui font références à requests. Les autres modules ne l'import pas, donc pas besoin.
Sylfwood
force-pushed
the
devops/features
branch
from
4c401e1 to
975485f
Compare
DannyBedard
previously approved these changes
Mar 24, 2025
DannyBedard
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve the functionality and maintainability of the codebase, particularly in the
.github/workflows/test.ymlfile and various module utility files. The changes include updates to the workflow, error handling improvements, and code formatting enhancements.