Skip to content

added path property to the returned objects #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

PatrickEPG
Copy link
Contributor

Hi,

I think its useful to see the path where a secret is located, so I added the path Property the returned Object.

@DannyBedard
Copy link
Contributor

Thank you for your contribution! Your idea is valuable, and I've reviewed and tested your changes. I've identified a few issues that need attention:

You can review the errors here:
https://github.com/Devolutions/ansible-dvls/actions/runs/14668797881/job/41170180956#step:10:1

Check secrets from file: Currently returns //// instead of //.

Check secrets from ID: The secret_path is not present because the corresponding function isn't executed.

Check secret from name: Currently returns //// instead of //.

Check created secret: Currently returns //// instead of //.

Additionally, we've recently added a CONTRIBUTING.md file to assist developers in setting up their development environment. This document provides guidelines for running integration tests locally to validate your changes thoroughly.

Please feel free to reach out if you have any questions or need further clarification. If you have suggestions or requests for additional features, you are welcome to use the issues section. However, please note that implementing feature requests might take some time.

@PatrickEPG
Copy link
Contributor Author

Thanks for the info. I initially though the implementation was just this one line, but it seems it requires a little bit more work than that.
Sadly I currently don't have the time to properly implement it, so I will close this PR.
Maybe I'll get back to it some time in the future.

@PatrickEPG PatrickEPG closed this May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants