Skip to content

Commit

Permalink
ci: fix pull_request check workflow for PRs coming from forks
Browse files Browse the repository at this point in the history
  • Loading branch information
CBenoit committed Oct 18, 2024
1 parent 7fb1dfe commit ce4d59f
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,7 @@ jobs:
name: devolutions-gateway [${{ matrix.os }} ${{ matrix.arch }}]
runs-on: ${{ matrix.runner }}
needs: [preflight, devolutions-gateway-web-ui]
if: always()
if: always() # The webapp can’t be build without secrets that we don’t provide for PRs coming from forks.
strategy:
matrix:
include: ${{ fromJson(needs.preflight.outputs.gateway-build-matrix) }}
Expand Down Expand Up @@ -508,6 +508,7 @@ jobs:
name: devolutions gateway merge artifacts
runs-on: ubuntu-latest
needs: [preflight, devolutions-gateway]
if: always() # The job is skipped for PRs coming from forks because the devolutions-gateway job would have been skipped (if always() wasn’t used). Another GitHub action oddity.

steps:
- name: Merge Artifacts
Expand All @@ -521,7 +522,6 @@ jobs:
name: devolutions-agent [${{ matrix.os }} ${{ matrix.arch }}]
runs-on: ${{ matrix.runner }}
needs: [preflight]
if: always()
strategy:
matrix:
include: ${{ fromJson(needs.preflight.outputs.agent-build-matrix) }}
Expand Down Expand Up @@ -718,10 +718,11 @@ jobs:
success:
name: Success
runs-on: ubuntu-latest
if: ${{ always() }}
if: always()
needs:
- tests
- jetsocat-lipo
- devolutions-gateway
- devolutions-gateway-merge
- devolutions-agent-merge
- dotnet-utils-tests
Expand Down

0 comments on commit ce4d59f

Please sign in to comment.