Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix pull_request check workflow for PRs coming from forks #1060

Merged
merged 1 commit into from
Oct 18, 2024
Merged

ci: fix pull_request check workflow for PRs coming from forks #1060

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,7 @@ jobs:
name: devolutions-gateway [${{ matrix.os }} ${{ matrix.arch }}]
runs-on: ${{ matrix.runner }}
needs: [preflight, devolutions-gateway-web-ui]
if: always()
if: always() # The webapp can’t be build without secrets that we don’t provide for PRs coming from forks.
strategy:
matrix:
include: ${{ fromJson(needs.preflight.outputs.gateway-build-matrix) }}
Expand Down Expand Up @@ -508,6 +508,7 @@ jobs:
name: devolutions gateway merge artifacts
runs-on: ubuntu-latest
needs: [preflight, devolutions-gateway]
if: always() # The job is skipped for PRs coming from forks because the devolutions-gateway job would have been skipped (if always() wasn’t used). Another GitHub action oddity.

steps:
- name: Merge Artifacts
Expand All @@ -521,7 +522,6 @@ jobs:
name: devolutions-agent [${{ matrix.os }} ${{ matrix.arch }}]
runs-on: ${{ matrix.runner }}
needs: [preflight]
if: always()
strategy:
matrix:
include: ${{ fromJson(needs.preflight.outputs.agent-build-matrix) }}
Expand Down Expand Up @@ -718,10 +718,11 @@ jobs:
success:
name: Success
runs-on: ubuntu-latest
if: ${{ always() }}
if: always()
needs:
- tests
- jetsocat-lipo
- devolutions-gateway
- devolutions-gateway-merge
- devolutions-agent-merge
- dotnet-utils-tests
Expand Down
Loading