Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gateway): add API to trigger Devolutions Gateway update #890

Merged
merged 3 commits into from
Jun 25, 2024

Conversation

pacmancoder
Copy link
Contributor

@pacmancoder pacmancoder commented Jun 18, 2024

Gateway side of updater feature started at #889

The update could be triggered with the following request:

GET /jet/update?version=2024.2.1

@pacmancoder pacmancoder self-assigned this Jun 18, 2024
@CBenoit CBenoit changed the title feat(gateway): Add API to trigger Gateway update feat(gateway): add API to trigger Devolutions Gateway update Jun 18, 2024
devolutions-gateway/src/api/update.rs Outdated Show resolved Hide resolved
devolutions-gateway/src/api/update.rs Outdated Show resolved Hide resolved
@pacmancoder pacmancoder changed the base branch from master to feat/agent-udpater June 18, 2024 15:27
Base automatically changed from feat/agent-udpater to master June 20, 2024 13:41
@pacmancoder pacmancoder marked this pull request as ready for review June 20, 2024 13:42
@CBenoit
Copy link
Member

CBenoit commented Jun 21, 2024

@pacmancoder I think you need to rebase on master

@pacmancoder
Copy link
Contributor Author

@CBenoit yep, I'll rebase today and add follow-up comment fixes from #889 (comment)

@CBenoit
Copy link
Member

CBenoit commented Jun 21, 2024

@pacmancoder Oh I didn’t see your message. I just sent follow PRs for these.

@pacmancoder
Copy link
Contributor Author

@CBenoit rebased and made refactoring

Copy link
Member

@CBenoit CBenoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that you need to run cargo format

Copy link
Member

@CBenoit CBenoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CBenoit CBenoit enabled auto-merge (squash) June 25, 2024 07:18
@CBenoit CBenoit merged commit 799e518 into master Jun 25, 2024
23 checks passed
@CBenoit CBenoit deleted the feat/gateway-update-api branch June 25, 2024 07:29
@CBenoit
Copy link
Member

CBenoit commented Jun 26, 2024

@pacmancoder I didn’t notice when merging but FYI the commit scope should be dgw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants