feat(dpapi): implement MS-GKDI and DPAPI Blob encoding/decoding #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CBenoit
reviewed
Jan 15, 2025
There was a problem hiding this comment.
Good work!
Remark on the Error type. It seems to me that the Error type is kind of becoming a big catch-all Error enum. It’s typically better to hand out more targeted errors to the users, so they can match on what matters for the domain. Had a similar discussion with Vlad recently: Devolutions/devolutions-gateway#1172 (comment)
Also saw this topic comes back in this blog post, as "umbrella errors": https://www.howtocodeit.com/articles/the-definitive-guide-to-rust-error-handling#umbrella-errors
Thanks to thiserror, it’s easier to create new smaller errors dedicated to the domain. Feel free to use it as much as needed.
CBenoit
reviewed
Jan 16, 2025
|
|
||
| /// Decodes a UTF-16–encoded byte slice into a [String]. | ||
| /// | ||
| /// The input `data` slice should has the size multiple of two (`data.len() % 2 == 0`). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I implemented MS-GKDI structures and DPAPI Blob encoding/decoding in this PR.
Docs & references: