Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ScrollController property #21

Merged
merged 1 commit into from
Sep 23, 2023

Conversation

AHED200
Copy link
Contributor

@AHED200 AHED200 commented Sep 18, 2023

Status

READY

Breaking Changes

YES

Description

I use this beautiful package in my project, but I have a little issue I can't add a ScrollController to manage the scroll position. So I added a new variable type of ScrollController to DraggableHome widget, specifically in CustomScrollView

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@AHED200 AHED200 requested a review from divshekhar as a code owner September 18, 2023 17:30
@4-alok
Copy link
Member

4-alok commented Sep 20, 2023

@AHED200 need to format the project before creating pull request.
Format using: dart format lib.

@AHED200
Copy link
Contributor Author

AHED200 commented Sep 20, 2023

@AHED200 need to format the project before creating pull request. Format using: dart format lib.

I already did. I see there is a problem with CI because you use a flutter command, not a dart command, flutter does not have a format command.

@AHED200 AHED200 requested a review from 4-alok September 22, 2023 10:12
@4-alok 4-alok merged commit 77004ca into DevsOnFlutter:main Sep 23, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants