Move prefix/port messages from on-detection to on-connection

.vscode/tasks.json

@@ -28,8 +28,7 @@
                     "env": {
                         "PATH": "C:\\msys64\\usr\\bin;c:\\msys64\\mingw64\\bin",
                         "MSYSTEM": "MINGW64",
-                        "CC": "gcc",
-                        "RACK_USER_DIR": "${OneDrive}\\Documents\\Rack2"
+                        "CC": "gcc"
                     },
                     "shell": {
                         "executable": "C:\\msys64\\usr\\bin\\bash.exe",

firmware/mock_hardware/common/ftdi.c

@@ -17,13 +17,13 @@ u8* ftdi_rx_buf(void)
     return 0;
 }
 
-u8 ftdi_rx_bytes(void)
+volatile u8 ftdi_rx_bytes(void)
 {
     return 0;
 }
 
-u8 ftdi_rx_busy(void) { return 0; }
-u8 ftdi_tx_busy(void) { return 0; }
+volatile u8 ftdi_rx_busy(void) { return 0; }
+volatile u8 ftdi_tx_busy(void) { return 0; }
 
 u8 ftdi_connected(void)
 {

firmware/mock_hardware/include/ftdi.h

@@ -13,7 +13,7 @@ void ftdi_change(uhc_device_t* dev, u8 plug);
 void ftdi_setup(void);
 
 u8* ftdi_rx_buf(void);
-u8 ftdi_rx_bytes(void);
-u8 ftdi_rx_busy(void);
-u8 ftdi_tx_busy(void);
+volatile u8 ftdi_rx_bytes(void);
+volatile u8 ftdi_rx_busy(void);
+volatile u8 ftdi_tx_busy(void);
 u8 ftdi_connected(void);

firmware/mock_hardware/mock_serial.c

@@ -72,7 +72,7 @@ u8* mock_serial_rx_buf(void)
     return mock_serial_current_message_buffer;
 }
 
-u8 mock_serial_rx_bytes(void)
+volatile u8 mock_serial_rx_bytes(void)
 {
     return mock_serial_current_message_length;
 }

lib/serialosc/SerialOsc.cpp

@@ -413,9 +413,6 @@ void SerialOsc::ProcessMessage(const osc::ReceivedMessage& m, const IpEndpointNa
             // wait until after size message recieved -MD
             // listener->deviceFound(device);
             sendDeviceInfoMessage(device->port);
-
-            sendDevicePrefixMessage(port);
-            sendDevicePortMessage(port);
         }
         else if (address == "/serialosc/remove")
         {

src/common/core/GridConnection/GridConnection.cpp

@@ -1,4 +1,5 @@
 #include "GridConnection.hpp"
+#include "SerialOscInterface.hpp"
 
 void GridConnectionManager::registerGrid(Grid* grid)
 {
@@ -76,6 +77,15 @@ void GridConnectionManager::connect(Grid* grid, IGridConsumer* consumer)
     consumerToGridMap[consumer] = grid;
     idToConsumerMap[grid->getDevice().id] = consumer;
     consumer->gridConnected(grid);
+
+    // If serialosc is managing the grid (e.g. it's a hardware grid), inform serialosc about new grid owner
+    auto port = grid->getDevice().port;
+    auto so = SerialOscInterface::get();
+    if (port > 0 && so != nullptr && so->driver != nullptr)
+    {
+        so->driver->sendDevicePrefixMessage(port);
+        so->driver->sendDevicePortMessage(port);
+    }
 }
 
 bool GridConnectionManager::isConnected(IGridConsumer* consumer)