Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"war" card game #371

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vedpawar2254
Copy link

PR Title

Added a War-card-game

Summary

summary...
simple Python script for a card game called War. The game is played between two players, and the player with the higher card wins each round. The game continues until one player has all the cards.

The changes are as follows:

  • Updated Readme
  • Added new python script for game

Checks

in the repository

  • Made no changes that degrades the functioning of the repository
  • Gave each commit a better title (unlike updated README.md)

in the PR

  • Followed the format of the pull_request_template
  • Made the Pull Request in a small level (for the creator's wellfare)
  • Tested the changes you made

Thank You,
ved

@vedpawar2254
Copy link
Author

Please consider this for hactober2024

Copy link
Collaborator

@hasan-py hasan-py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The head ref may contain hidden characters: ""WAR"-card-game"
Please fix this

@@ -0,0 +1,102 @@
from random import shuffle
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you consider to add a readme instruction for thsi script?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants