Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added validations fixes #572 #687

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Hamza1821
Copy link

🚀 Pull Request

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

vercel bot commented Oct 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ice-cream-parlour-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 19, 2024 7:40am

Copy link
Owner

@DharshiBalasubramaniyam DharshiBalasubramaniyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When i am submitting the sign up form without entering any data, the form is still submitting. it doesn't show any error messages.

Can you check that?

@Hamza1821
Copy link
Author

@DharshiBalasubramaniyam i have updated validation forms now check

@DharshiBalasubramaniyam
Copy link
Owner

Resolve conflicts and why did you removed the password validity meter?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc-ext hacktoberfest-accepted question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Adding Name , Email vaildation check for login and Signup pages
2 participants