Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the image quality in DINE-IN page. #761

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ApoorvaSunkad
Copy link

🚀 Pull Request

Description

Hi,

The image quality of 2 images on the DINE-IN page (see the screenshots) was poor. It did not match other image quality to enhance the overall image quality and the website. I have added 2 new images of a similar type to the previous image in the images folder and then added them to dine-in.html also to fit the aspect ratio of the container I have provided the property "object-fit: cover".

I have also added comments for better understanding.

Kindly merge my Pull Request.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshot of final output/video

BEFORE
icy1

AFTER
icy2
icy3

Thank you for allowing me to contribute and learn new things. Happy Coding!

Copy link

vercel bot commented Oct 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ice-cream-parlour-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 20, 2024 2:37pm

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you @ApoorvaSunkad for your contribution! Your pull request has been submitted successfully. A maintainer will review it as soon as possible. We appreciate your support in making this project better

@DharshiBalasubramaniyam
Copy link
Owner

Resolve conflicts!

@ApoorvaSunkad
Copy link
Author

ApoorvaSunkad commented Oct 19, 2024

Hi @DharshiBalasubramaniyam ,

Resolved the conflict occurred. Kindly check once and merge my Pull Request.

Thank you!

Copy link
Owner

@DharshiBalasubramaniyam DharshiBalasubramaniyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why you updated the styles.css?

@ApoorvaSunkad
Copy link
Author

ApoorvaSunkad commented Oct 20, 2024

Hi @DharshiBalasubramaniyam ,

When I was searching for the dine-in.css style page I could not find it, hence I updated it in styles.css by adding a property called object-fit: cover so the images fit the container and their aspect-ratio is also not distorted. Upon checking today, I found the dine-in.css page and will update it, and remove the changes from styles.css. I apologize for my mistake as this is my 1st open-source contribution at GSSOC'24.

Can I update the dine-in.css page with my changes? Could you please let me know?

Thank You!

@ApoorvaSunkad
Copy link
Author

Hi @DharshiBalasubramaniyam ,

I removed the style applied in the styles.css page and added it in dine-in.css. Kindly let me know if this is correct.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc-ext hacktoberfest-accepted question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

To fix the image quality in DINE IN page
2 participants