-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed the image quality in DINE-IN page. #761
base: master
Are you sure you want to change the base?
Fixed the image quality in DINE-IN page. #761
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Thank you @ApoorvaSunkad for your contribution! Your pull request has been submitted successfully. A maintainer will review it as soon as possible. We appreciate your support in making this project better
Resolve conflicts! |
Resolved the conflict occurred. Kindly check once and merge my Pull Request. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why you updated the styles.css?
When I was searching for the dine-in.css style page I could not find it, hence I updated it in styles.css by adding a property called object-fit: cover so the images fit the container and their aspect-ratio is also not distorted. Upon checking today, I found the dine-in.css page and will update it, and remove the changes from styles.css. I apologize for my mistake as this is my 1st open-source contribution at GSSOC'24. Can I update the dine-in.css page with my changes? Could you please let me know? Thank You! |
I removed the style applied in the styles.css page and added it in dine-in.css. Kindly let me know if this is correct. Thank you! |
🚀 Pull Request
Description
Hi,
The image quality of 2 images on the DINE-IN page (see the screenshots) was poor. It did not match other image quality to enhance the overall image quality and the website. I have added 2 new images of a similar type to the previous image in the images folder and then added them to dine-in.html also to fit the aspect ratio of the container I have provided the property "object-fit: cover".
I have also added comments for better understanding.
Kindly merge my Pull Request.
Checklist:
Screenshot of final output/video
BEFORE
AFTER
Thank you for allowing me to contribute and learn new things. Happy Coding!