Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#600 Search Bar Added #786

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

#600 Search Bar Added #786

wants to merge 3 commits into from

Conversation

Yash-Jadaun
Copy link
Contributor

@Yash-Jadaun Yash-Jadaun commented Oct 19, 2024 •
edited
Loading

🚀 Pull Request

Description

I added a Search bar in website. @DharshiBalasubramaniyam plz merge my pr.

  • Fixes #(600)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
    Screenshot (1153)

Screenshot of final output/video

@vercel Vercel
Copy link

vercel bot commented Oct 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ice-cream-parlour-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 19, 2024 4:27pm

@DharshiBalasubramaniyam
Copy link
Owner

#600

DharshiBalasubramaniyam
DharshiBalasubramaniyam requested changes Oct 20, 2024
View reviewed changes
Copy link
Owner

@DharshiBalasubramaniyam DharshiBalasubramaniyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ui is not looking good. Can you improve it.

@Yash-Jadaun
Copy link
Contributor Author

Yes Offcourse I will improve the UI. @DharshiBalasubramaniyam

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DharshiBalasubramaniyam DharshiBalasubramaniyam DharshiBalasubramaniyam requested changes

Assignees

@Yash-Jadaun Yash-Jadaun

Labels
gssoc-ext hacktoberfest-accepted question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yash-Jadaun @DharshiBalasubramaniyam