Pattern fix #920
Closed
Pattern fix #920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RMSD calculation is very slow, so turning it off by default until a faster method is found.
…iterative loops Before this change, the hardcoded setting of `max_frames` of these extra `PluginData` objects to `'single'` was potentially causing the input data being given to plugins in iterations > 0 to be different than desired. In the context of iterative alignment, this bug was causing the `ForwardProjectorGpu` plugin to be given 3D data (as expected) on iteration 0, but 2D data (not as expected) on iteration 1, resulting in an error. Appropriately setting `max_frames` of these extra `PluginData` objects resolves this issue. (As a side note, you can refer to 27c132c to see when these extra `PluginData` objects were first introduced in the context of pattern-switching).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick fix for issue to do with patterns in the statistics class.