Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIMS-1286: Show ERA status on calendar and visits list #834

Conversation

ndg63276
Copy link
Collaborator

JIRA ticket: LIMS-1286

Summary:

Users (and staff) often don't realise their ERA has not been validated as the visit approaches, so we should display it more prominently.

Changes:

  • Get risk rating for each session from ISPyB (it should be synced to UAS)
  • Display a green/yellow/red circle for low/medium/high risk sessions, and a black circle if the ERA has not been approved yet, on both the calendar page and also the visits list page
  • Display a tooltip to explain the circle if a user hovers over it

To test:

  • Go to an MX proposal (eg /dc/visit/mx37045-1) and then click the calendar link at the top left. As staff you should see lots of visits for the mx village, check a coloured circle appears next to each, and a tooltip appears if you hover over it. Check there are some green, yellow and black.
  • Go to the /visits page, check there is an ERA column with the same circles and tooltip.
  • Go to proposal mx18802 and check the visits list, this proposal has High risk sessions from May 2018, so should have red circles.

Copy link
Collaborator

@NKatti2011 NKatti2011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndg63276 ndg63276 changed the base branch from master to pre-release/2024-R4.4 October 1, 2024 09:52
@ndg63276 ndg63276 merged commit d09aa59 into pre-release/2024-R4.4 Oct 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants