LIMS-1612: Replace uniqid with openssl random pseudo bytes #903
+60
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfrn
changed the title
|
Sorry to be a pain, but now that #852 has been merged into master, there is another place we should use the new utility function. Can you merge master into this and then check Shipping.php line 3156 (ish)? |
* LIMS-1590: Dont allow name editing for lab contacts when login is set (#887) * LIMS-1558: Add functionality for SMILES code for any sample (#880) * LIMS-1490: Use callback URL for incoming dewars via shipping service (#852) * LIMS-1570: Remove unused app file (#874) * LIMS-1537: Add more options to reprocessing (#876) * LIMS-1466: Disable dispatch form validation when using the shipping service (#891)
|
No problem. Will have a look now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA ticket: LIMS-1612
Summary:
Removal of all usage of php's uniqId as its is known to be cryptographically insecure. Replaced with openssl_pseudo_random_bytes instead.
All uses of uniqId were being passed into md5() so added a common utility fn for that purpose.
Changes:
To test: