Add win32 support #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make adPython work on Windows. Change how adPython calls into the embedded Python to use PyGILState_Ensure() and PyGILState_Release() which is appropriate for calling from non-Python-created threads which is the case for adPython which is called from areaDetector-created threads. Without this change, adPython hangs on Windows. The Python calling idiom is documented in the following: * https://docs.python.org/2/c-api/init.html#non-python-created-threads * https://stackoverflow.com/a/4975906 * https://bugs.python.org/issue1720250#msg57619 Install the plugin scripts so that adPython can reference an installed pathname rather than a source pathname. Remove the automatic determination of the Python version, include pathnames, library pathnames, etc. by executing external commands from Make since it did not work on Windows. Replace that with explicit definitions in configure/CONFIG_SITE.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make adPython work on Windows.
Change how adPython calls into the embedded Python to use
PyGILState_Ensure() and PyGILState_Release() which is appropriate for
calling from non-Python-created threads which is the case for adPython
which is called from areaDetector-created threads. Without this change,
adPython hangs on Windows. The Python calling idiom is documented in
the following:
Install the plugin scripts so that adPython can reference an installed
pathname rather than a source pathname.
Remove the automatic determination of the Python version, include
pathnames, library pathnames, etc. by executing external commands from
Make since it did not work on Windows. Replace that with explicit
definitions in configure/CONFIG_SITE.