Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update policy to use static admin data #181

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

tpoliaw
Copy link
Collaborator

@tpoliaw tpoliaw commented Oct 3, 2024

No description provided.

The mapping from admin groups to which beamlines they refer to allows
the access functions to be greatly simplified. Also adds functions to
differentiate between users that are on a proposal/session and those
that can access it due to being an admin for that beamline.
Copy link
Member

@garryod garryod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Though would like to have the bundler deployed with the appropriate data before we merge policy requiring it. I.e. #167 plus the addition of a configmap which deploys the static files

@tpoliaw
Copy link
Collaborator Author

tpoliaw commented Oct 3, 2024

Sure, definitely needs to wait a while before being merged

Copy link
Member

@garryod garryod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@garryod garryod merged commit e241157 into DiamondLightSource:main Oct 10, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants