Beamline policy rules #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
RE failing lints. The suggested changes change the behaviour so I 'm not sure if I'm trying to work against the way OPA expects rules to be written by making them undefined when the input is not present. |
tpoliaw
force-pushed
the
beamline_rules
branch
from
f6e433c
to
afc4380
Compare
garryod
reviewed
Oct 10, 2024
tpoliaw
force-pushed
the
beamline_rules
branch
2 times, most recently
from
48908c7
to
a241bbb
Compare
garryod
reviewed
Oct 11, 2024
tpoliaw
force-pushed
the
beamline_rules
branch
3 times, most recently
from
3420bc4
to
ae8b7d6
Compare
garryod
previously approved these changes
Oct 16, 2024
tpoliaw
force-pushed
the
beamline_rules
branch
from
ae8b7d6
to
47c469f
Compare
* session.access: user can access session * session.named_user: user is a named member of the visit * session.matches_beamline: visit is on the given beamline * session.session_beamline: beamline for the given visit * proposal.access: user can access proposal * proposal.named_user: user is a named user on the proposal * admin.admin: user is super admin * admin.beamline_admin: user is admin for the given beamline Rules are only defined if the required fields are included in the input. `admin.beamline_admin` refers to the beamline passed as `input.beamline` not as the beamline for the session defined by `proposal`+`visit`. Previous function `session.beamline` has been renamed to `beamline_for` to distinguish it from the `session.beamline` rule. User is determined from token passed as `input.token`.
tpoliaw
force-pushed
the
beamline_rules
branch
from
47c469f
to
6bbf22b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting as a draft for now as I'm sure there must be a better way of doing it. The aim was to make the rules only defined if the required fields are present in the input but still be present (but false) if the conditions weren't met. eg
input = {}=>result = {}input = {"user": "name"}=>result = {"admin": true}orresult = {"admin": false}.Setting the default to
falsewould probably be ok but means you could get misleading results, eg if you passuser,proposalandvisit, gettingbeamline_admin = falseback suggests the user is not the admin for the beamline for the visit which may or may not be correct.