separate the init config in helm #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiamondJoseph
requested changes
Sep 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #631 +/- ##
=======================================
Coverage 92.66% 92.66%
=======================================
Files 35 35
Lines 1663 1663
=======================================
Hits 1541 1541
Misses 122 122 ☔ View full report in Codecov by Sentry. |
callumforrester
approved these changes
Sep 11, 2024
DiamondJoseph
requested changes
Sep 11, 2024
Comment on lines
+83
to
+84
| extraEnvVars: | ||
| [] |
There was a problem hiding this comment.
Suggested change
| extraEnvVars: | |
| [] | |
| extraEnvVars: [] |
There was a problem hiding this comment.
my yaml parser corrects to the way it was,
There was a problem hiding this comment.
I just don't like unrelated changes :(
There was a problem hiding this comment.
I'm literally editing the same file and this is just a one line difference
DiamondJoseph
approved these changes
Sep 11, 2024
stan-dot
deleted the
620-init-container-cannot-be-run-when-mounting-configuration-values-from-envvars-without-also-mounting-those-envvars-to-the-init-container
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
long branch name due to @DiamondJoseph choice of words in the issue name, but at least it's entertaining