No dls bluesky #645
Merged
No dls bluesky #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiamondJoseph
temporarily deployed
to
release
GitHub Actions
Inactive
DiamondJoseph
force-pushed
the
no-dls-bluesky
branch
from
7395e95
to
f8d8fef
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #645 +/- ##
==========================================
- Coverage 92.33% 92.28% -0.06%
==========================================
Files 35 35
Lines 1800 1801 +1
==========================================
Hits 1662 1662
- Misses 138 139 +1 ☔ View full report in Codecov by Sentry. |
Merged
4 tasks
callumforrester
approved these changes
Oct 11, 2024
DiamondJoseph
force-pushed
the
no-dls-bluesky
branch
from
cd54faf
to
8e71662
Compare
DiamondJoseph
force-pushed
the
no-dls-bluesky
branch
from
75c446f
to
e305a25
Compare
| @@ -204,8 +204,8 @@ def temp_yaml_config_file( | |||
| "env": { | |||
| "sources": [ | |||
| {"kind": "dodal", "module": "dodal.adsim"}, | |||
| {"kind": "planFunctions", "module": "dls_bluesky_core.plans"}, | |||
| {"kind": "planFunctions", "module": "dls_bluesky_core.stubs"}, | |||
| {"kind": "planFunctions", "module": "dodal.plans"}, | |||
There was a problem hiding this comment.
I probably missed this in the last PR, but what happens if I just want to import some of the dodal plans, not all of them?
There was a problem hiding this comment.
In theory, not just for dodal.plans but for any plans module, you maintain a structure such that x.y.z is the plans you want imported, and x.y.a is plans that you don't want imported.
This is also why dodal.plan_stubs.wrapped on the line below.
Until we can tackle #681
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #643